Integrated: pr: only act on commit comments on known branches
Erik Helin
ehelin at openjdk.java.net
Wed Feb 24 15:43:23 UTC 2021
On Wed, 24 Feb 2021 14:48:37 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this patch that makes the `CommitCommentsWorkItem` filter out commit comments that aren't made on commits on a known branch in the remote repository. Some forges can return comments on commits in pull requests, which aren't comments we want to act upon (commit commands are only for integrated commits on a known branch).
>
> Testing:
> - [x] Added a unit test
> - [x] `make test` passes on Linux x64
>
> Thanks,
> Erik
This pull request has now been integrated.
Changeset: fea182b7
Author: Erik Helin <ehelin at openjdk.org>
URL: https://git.openjdk.java.net/skara/commit/fea182b7
Stats: 94 lines in 3 files changed: 83 ins; 7 del; 4 mod
pr: only act on commit comments on known branches
Reviewed-by: rwestberg
-------------
PR: https://git.openjdk.java.net/skara/pull/1034
More information about the skara-dev
mailing list