RFR: Add dependency information for initial RFR mail of a dependent PR
Erik Helin
ehelin at openjdk.java.net
Thu Jan 21 15:40:13 UTC 2021
On Thu, 21 Jan 2021 14:11:14 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> When sending out an RFR email for a dependent PR, include a line describing the dependency.
Looks good! Just a minor nit, I would have used the wording `"Depends on"` instead of `"Depends on PR"` :smiling_face_with_three_hearts:
bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java line 264:
> 262:
> 263: var dependsPr = pr.repository().pullRequest(dependsId.get());
> 264: return Optional.of("Depends on PR: " + dependsPr.webUrl());
Suggestion:
return Optional.of("Depends on: " + dependsPr.webUrl());
bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java line 3277:
> 3275:
> 3276: assertTrue(archiveContains(archiveFolder.path(), "Depends on PR:", pr.id()));
> 3277: assertFalse(archiveContains(archiveFolder.path(), "Depends on PR:", depPr.id()));
Suggestion:
assertTrue(archiveContains(archiveFolder.path(), "Depends on:", pr.id()));
assertFalse(archiveContains(archiveFolder.path(), "Depends on:", depPr.id()));
-------------
Marked as reviewed by ehelin (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/991
More information about the skara-dev
mailing list