RFR: 1085: Gitlab PR has bad link to patch file [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Jul 6 12:41:21 UTC 2021

On Tue, 6 Jul 2021 12:34:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The link generated under the "Reviewing" header in a PR description works fine on Github, but on Gitlab, the link has a Github style form which does not work.
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>   Stop GitLab URL mangling

So, it turned out that GitLab is a bit too smart for it's own best... If it finds that a part of a URL matches a MR, it will rewrite it to "!<MR number>", e.g. "!99". So the diff URLs got converted to `!99.diff`. Which the javascript, or whatever, that should have restored the full MR URL, could not detect and rewrite back to the proper URL. *sigh* I worked around this by adding a double slash, which throw off the pattern detector.


PR: https://git.openjdk.java.net/skara/pull/1191

More information about the skara-dev mailing list