RFR: 1091: "PR body must not be empty" check pointless for clean backports

Kevin Rushforth kcr at openjdk.java.net
Thu Jul 15 11:58:26 UTC 2021

On Thu, 15 Jul 2021 11:15:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch removes the requirement to write something in the PR body for clean backports. Most of the time there really is nothing to add in that case.

Looks good. I left one question inline, but presume the answer is "no problem".

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 892:

> 890:             var isCleanBackport = false;
> 891:             if (original.isPresent()) {
> 892:                 isCleanBackport = updateClean(original.get());

This looks fine as long as there is no problem calling `backportedFrom()` and `updateClean()` earlier than was done previously.


Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1201

More information about the skara-dev mailing list