RFR: 1051: JCheck complains about issue already used

[Erik Joelsson]

On Wed, 2 Jun 2021 20:31:37 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> The DuplicateIssuesCheck can sometimes report false positives when the same issueId has been used in separate branches. This patch fixes the check so that only commits that are ancestors of the commit being checked are considered.
>
> jcheck/src/main/java/org/openjdk/skara/jcheck/DuplicateIssuesCheck.java line 77:
> 
>> 75:         for (var issue : message.issues()) {
>> 76:             var hashes = issuesToHashes.get(issue.id());
>> 77:             if (hashes != null) {
> 
> You can save the additional processing if `hashes.size()` is 1, so I recommend leaving this test as it was before:
> 
> 
> if (hashes != null && hashes.size() > 1) {

Good point.

-------------

PR: https://git.openjdk.java.net/skara/pull/1178