Integrated: 997: Email notifications are not sent to alias if binary change is commented in Gitlab

Erik Joelsson erikj at openjdk.java.net
Thu Jun 17 13:19:10 UTC 2021


On Wed, 16 Jun 2021 23:46:40 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This fixes an NPE when parsing a review comment from Gitlab on a binary file. Such a comment does not have a line, and I picked the value 0 to signal that. I also updated the email formatting of such comments to skip showing line numbers and quotes from the file.

This pull request has now been integrated.

Changeset: c11e604d
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/c11e604decf783ef940a083aa22a5493c577aa79
Stats:     48 lines in 3 files changed: 31 ins; 3 del; 14 mod

997: Email notifications are not sent to alias if binary change is commented in Gitlab

Reviewed-by: kcr

-------------

PR: https://git.openjdk.java.net/skara/pull/1190


More information about the skara-dev mailing list