RFR: 912: PR title correction logic can get stuck [v3]

Robin Westberg rwestberg at openjdk.java.net
Fri Mar 12 11:56:51 UTC 2021

On Fri, 12 Mar 2021 10:41:44 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The PR title correct logic introduced with SKARA-572 can end up trying to correct the title forever. An observed case is where the JBS title ends with a trailing space. When trying to update the PR title to include this trailing space, it will be stripped by GitLab and no update will actually be done. This will then get retried again and again. 
>> The fix is to strip the JBS title before doing any comparisons.
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>   Move strip() into implementation of title(), as requested by reviewer.

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1050

More information about the skara-dev mailing list