RFR: Add support for using ssh cloning with GitLab

[Magnus Ihse Bursie]

On Mon, 15 Mar 2021 10:39:44 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Add support for configuring a GitLab forge to use ssh for cloning repositories using a private ssh key.

forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabForgeFactory.java line 71:

> 69: 
> 70:         try {
> 71:             Files.writeString(cfgFile, result + filtered.strip() + "\n", StandardCharsets.UTF_8);

Can this result in us writing to a users .ssh/config when running Skara CLI tools?

forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabForgeFactory.java line 63:

> 61:         var existingMatcher = existingBlock.matcher(existing);
> 62:         var filtered = existingMatcher.replaceAll("");
> 63:         var result = "Match host=" + userHost + "\n" +

I don't think this is valid .ssh/config syntax. Afaik it should be `Match <keyword> <value>`, that is, no `=`. I see no tests in this PR. Are you sure this works?

-------------

PR: https://git.openjdk.java.net/skara/pull/1057