RFR: Add support for using ssh cloning with GitLab

Magnus Ihse Bursie ihse at openjdk.java.net
Mon Mar 15 12:40:39 UTC 2021


On Mon, 15 Mar 2021 12:36:09 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabForgeFactory.java line 71:
>> 
>>> 69: 
>>> 70:         try {
>>> 71:             Files.writeString(cfgFile, result + filtered.strip() + "\n", StandardCharsets.UTF_8);
>> 
>> Can this result in us writing to a users .ssh/config when running Skara CLI tools?
>
> No, CLI tools never pass a configuration object when creating a Forge.

Good.

-------------

PR: https://git.openjdk.java.net/skara/pull/1057


More information about the skara-dev mailing list