RFR: Add support for using ssh cloning with GitLab [v2]
Robin Westberg
rwestberg at openjdk.java.net
Mon Mar 15 13:10:09 UTC 2021
On Mon, 15 Mar 2021 12:48:16 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Yes, tested it manually and seems to work fine. And no, there are no automated tests that exercise GitLab or GitHub APIs, except for running them with a special credential configuration..
>
> I still think this does not follow the documented ssh config file syntax (https://man7.org/linux/man-pages/man5/ssh_config.5.html). And even if that works on your machine right now, it can break on a future update of ssh.
> Configuration options may be separated by whitespace or optional whitespace and exactly one ‘=’
Still, works without it as well, so can certainly change it..
-------------
PR: https://git.openjdk.java.net/skara/pull/1057
More information about the skara-dev
mailing list