Using PR /test instead of jdk-submit: "You need to get approval"

[Man Cao]

Hi Skara developers,

I tried to use the /test PR command in
https://github.com/openjdk/jdk/pull/2986, and got the same "you need to get
approval" message.
Is the "/test" command supposed to work now?

Also, I highly appreciate updating the wiki page
<https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/test>
to elaborate the procedure to use the /test command.
Who can use it with or without the approval step? How does the approval
process go?

I also found presubmit tests using GitHub actions
<https://wiki.openjdk.java.net/display/SKARA/Testing>, which I can launch
and it is currently queued.
Do the presubmit tests provide similar coverage as the "/test" command? Is
it preferred over the "/test" command?

Thanks,
-Man


On 9/9/20 9:49 AM, Aleksey Shipilev wrote:
> >* Hi,
> *> >* Now I have questions for jdk-submit-like functionality :)
> *> >* Look at this PR:
> *>*    https://github.com/openjdk/jdk/pull/92 <https://github.com/openjdk/jdk/pull/92>
> *> >* When both "/test tier1" and "/test builds" is requested, the bot replies:
> *>*   "@shipilev you need to get approval to run the tests in tier1 for
> *>* commits up to ..."
> *> >* I am confused about what that means. Does it mean I have to have some
> *>* additional privileges to use /test? Does it mean the PR should be
> *>* Reviewed first? Either way, I think the message should be a bit more clear.
> *
> The bot powering the /test command is feeling so-so at the moment, see
> my reply to Yasumasa on jdk-dev [0]. I'm hoping to find some cycles to
> fix this today, but there are few other bugs with high prio to handle at
> the moment too :/
> I should have this fixed by end of this week, sorry for any
> inconveniences this may have caused.
> Thanks,
> Erik
> [0]:
> https://mail.openjdk.java.net/pipermail/jdk-dev/2020-September/004702.html