RFR: cli: make it possible to configure forge name

Robin Westberg rwestberg at openjdk.java.net
Thu Mar 18 09:18:21 UTC 2021


On Thu, 18 Mar 2021 08:33:34 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes it possible to configure the forge name for a repository using `git config forge.name`, for example `git config forge.name github`. This can be useful for speeding up the forge selection logic in `Forge.from` so that the code doesn't have to query multiple candidate forges.
> 
> Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Looks good in general, but how about also storing this configuration automatically as well when auto-detection completes successfully (if it's not configured yet)? That way everyone could benefit from it on subsequent runs without having to configure it manually.

-------------

PR: https://git.openjdk.java.net/skara/pull/1076


More information about the skara-dev mailing list