Integrated: 744: The "Webrevs" link in the PR has confusing link to the changes for just one commit
Erik Helin
ehelin at openjdk.java.net
Thu Mar 18 10:27:38 UTC 2021
On Thu, 18 Mar 2021 09:10:31 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this pull request that makes the link to the commit after the webrev be a bit more useful. Previously we relied on the forge to "do the right thing" we it noticed a full hash to a commit (link to the changes). This worked fine on GitLab but didn't work as well on GitHub. I have now introduced a proper abstraction and use that to provide the same link on GitLab but a better link on GitHub.
>
> Thanks,
> Erik
This pull request has now been integrated.
Changeset: f16663b7
Author: Erik Helin <ehelin at openjdk.org>
URL: https://git.openjdk.java.net/skara/commit/f16663b7
Stats: 25 lines in 6 files changed: 24 ins; 0 del; 1 mod
744: The "Webrevs" link in the PR has confusing link to the changes for just one commit
Reviewed-by: rwestberg
-------------
PR: https://git.openjdk.java.net/skara/pull/1077
More information about the skara-dev
mailing list