RFR: 323: ArgumentParser should support --version

Robin Westberg rwestberg at openjdk.java.net
Thu Mar 18 10:53:42 UTC 2021


On Thu, 18 Mar 2021 10:42:50 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes the CLI tools **not** show an error when required flags and inputs are missing _and_ the flag `--version` is specified. If a user runs `git <tool> --version` then they shouldn't have to add required flags or input, they just want to see the version.
> 
> Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1078


More information about the skara-dev mailing list