[cr] RFR: 658: Webrev frame view does not have an indication of the current file
Erik Helin
ehelin at openjdk.java.net
Wed Mar 31 08:36:37 UTC 2021
Hi all,
please review this patch that makes the fragment (the part in the URL after the `#`) include the filename, not only the view and file number. This makes it easier in particularly the "Frames" view to see the filename of the file being changed (although browsers like Safari and Chrome nowadays hide parts of the URL by default). This also makes webrev.js more similar to the old webrev.ksh which included the filename in almost all URLs.
Testing:
- Local testing using Firefox on Linux x64
Thanks,
Erik
-------------
Commit messages:
- skara-658
Changes: https://git.openjdk.java.net/cr/pull/5/files
Webrev: https://webrevs.openjdk.java.net/?repo=cr&pr=5&range=00
Issue: https://bugs.openjdk.java.net/browse/SKARA-658
Stats: 18 lines in 1 file changed: 5 ins; 0 del; 13 mod
Patch: https://git.openjdk.java.net/cr/pull/5.diff
Fetch: git fetch https://git.openjdk.java.net/cr pull/5/head:pull/5
PR: https://git.openjdk.java.net/cr/pull/5
More information about the skara-dev
mailing list