RFR: bot: add liveness handler
Erik Joelsson
erikj at openjdk.java.net
Wed May 12 19:57:45 UTC 2021
On Wed, 12 May 2021 19:40:38 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Hi all,
>>
>> please review this patch that adds a liveness handler to the bot runner's HTTP server. The liveness handler, typically acting on the `/healthz` path, returns `200` if everything is well and `500` otherwise.
>>
>> Thanks,
>> Erik
>
> bot/src/main/java/org/openjdk/skara/bot/BotRunner.java line 241:
>
>> 239:
>> 240: boolean isHealthy() {
>> 241: return true;
>
> I think this implementation is a tad optimistic regarding the health of the runner. :) But I also think defining healthy can be tricky.
I don't have any better idea right now. We may want to revisit this later.
-------------
PR: https://git.openjdk.java.net/skara/pull/1155
More information about the skara-dev
mailing list