[cr] RFR: 1015: Webrev can't handle changes with binary files [v2]

Erik Joelsson erikj at openjdk.java.net
Mon May 17 13:46:39 UTC 2021


> Please review this fix, which fixes handling of binary files in webrev diffs. We should not even attempt to show diffs for binary files.

Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

  Adjusted for review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/cr/pull/16/files
  - new: https://git.openjdk.java.net/cr/pull/16/files/2533bd59..e3c2a7b1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=cr&pr=16&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=cr&pr=16&range=00-01

  Stats: 87 lines in 1 file changed: 35 ins; 33 del; 19 mod
  Patch: https://git.openjdk.java.net/cr/pull/16.diff
  Fetch: git fetch https://git.openjdk.java.net/cr pull/16/head:pull/16

PR: https://git.openjdk.java.net/cr/pull/16


More information about the skara-dev mailing list