[cr] RFR: 1015: Webrev can't handle changes with binary files [v2]

Erik Helin ehelin at openjdk.java.net
Mon May 17 17:59:34 UTC 2021


On Mon, 17 May 2021 13:46:39 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Please review this fix, which fixes handling of binary files in webrev diffs. We should not even attempt to show diffs for binary files.
>
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjusted for review comments

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/cr/pull/16


More information about the skara-dev mailing list