Integrated: 1036: Extend bot config files to support comments

Erik Helin ehelin at openjdk.java.net
Mon May 17 18:00:09 UTC 2021


On Mon, 17 May 2021 13:30:17 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that extends the `JSON` parser to optionally allow both comments and trailing commas (i.e. [JWCC](https://nigeltao.github.io/blog/2021/json-with-commas-comments.html)). I also modified the bot launcher to now use JWCC for its configuration files instead of plain JSON (to allow comments and trailing commas). Note that no other code is updated to use JWCC, so all networking code etc. will still use regular old JSON.
> 
> I also added a bunch of tests for the new JWCC "mode".
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: f4a18b3b
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/f4a18b3bc7a433af637dbfdc484f8068f31a036c
Stats:     343 lines in 4 files changed: 337 ins; 0 del; 6 mod

1036: Extend bot config files to support comments

Reviewed-by: erikj

-------------

PR: https://git.openjdk.java.net/skara/pull/1159


More information about the skara-dev mailing list