RFR: 1242: The /clean command for backports is ignored

Kevin Rushforth kcr at openjdk.java.net
Wed Nov 17 14:36:08 UTC 2021


On Wed, 17 Nov 2021 14:22:03 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> When dealing with backport pull requests, Skara tries to automatically determine if the backport is "clean". This automatic check is rather picky, so the user is supposed to be able to override this result with the command "/clean". Issuing the command works so far as the bot will react to it and add the "clean" label, but then it will ignore the label and still not consider the pull request clean.
> 
> This patch fixes this and updates the test to also verify that the pull request gets the "ready" label.

The fix looks fine. I see that there are failing Linux tests. Can you check whether this is a glitch or a real test failure?

-------------

PR: https://git.openjdk.java.net/skara/pull/1239


More information about the skara-dev mailing list