RFR: 1252: Improve the output message about the command `csr`

Erik Joelsson erikj at openjdk.java.net
Mon Nov 22 14:02:50 UTC 2021


On Mon, 22 Nov 2021 09:58:13 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> Currently, when a user, who is not the author of the pr and is not a reviewer, uses the command `/csr unneeded`, the bot will output the message `only the pull request author and [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to require a CSR.`. The message is good when meeting the command `/csr` or `/csr needed` but it is not good when meeting the command `/csr unneeded` or `/csr uneeded`.
> 
> This patch changes the message `are allowed to require a CSR` to `are allowed to use the csr command` and adds the corresponding test cases.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

Looks good, thanks for fixing this!

-------------

Marked as reviewed by erikj (Lead).

PR: https://git.openjdk.java.net/skara/pull/1243


More information about the skara-dev mailing list