RFR: 286: Add more info about CSR in the PR's first comment [v3]

Guoxiong Li gli at openjdk.java.net
Wed Nov 24 16:06:06 UTC 2021

On Wed, 24 Nov 2021 16:02:47 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch adds a link to the csr in the PR's first comment under **Issue**.
>> And the corresponding test is added.
>> Thanks for taking the time to review.
>> Best Regards,
>> -- Guoxiong
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Dont throw exception. Add CSR tag. Avoid the issue type intergration blocker.

Thanks for the review. I updated the code just now.

> I would suggest a bold CSR within normal parentheses after the title.


> I don't think we should throw an exception here


And I find the intergration blocker shouldn't invoke the method `CheckRun#issues` directly, so I add a parameter `withCsr` to the method `CheckRun#issues` to separate these two situations.


PR: https://git.openjdk.java.net/skara/pull/1244

More information about the skara-dev mailing list