RFR: 1071: auto-set `/csr` flag from JBS state

Kevin Rushforth kcr at openjdk.java.net
Wed Nov 24 17:42:06 UTC 2021

On Wed, 24 Nov 2021 15:57:55 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> Currently, the author of the PR or a reviewer could type `/csr` in the comment to direct the need of the CSR.
> It is good for the bot to automatically scan the `scr for` link and set the `csr` label for the PR.
> This patch adds the automatically scanning feature. And the corresponding tests are added.
> Thanks for taking the time to review.
> Best Regards,
> -- Guoxiong

The primary way that I use the `/csr` command is as a Reviewer to indicate that a PR needs to have a CSR when one might not yet exist. In some cases, the PR author might not realize that a CSR is needed. So the `/csr` command is definitely needed for this case.

I also agree with Erik that the CSR bot should not modify anything in JBS.

The automatic detection of an already-existing CSR in JBS seems like a "nice to have" feature for the case where a CSR already exists prior to creating the PR, so that the author (or a Reviewer) doesn't have to remember to say `/csr needed` explicitly, but we still need to be able to manually set it (and clear it in the case where further discussion indicates that a CSR really isn't needed).


PR: https://git.openjdk.java.net/skara/pull/1245

More information about the skara-dev mailing list