RFR: 1071: auto-set `/csr` flag from JBS state

Guoxiong Li gli at openjdk.java.net
Mon Nov 29 16:26:31 UTC 2021


On Wed, 24 Nov 2021 19:31:57 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Yes there is a closed "Withdrawn" state, but I would probably prefer a Reviewer to issue the `/csr unneeded` in that case. Otherwise, A PR author with the role of Committer could withdraw a CSR that a Reviewer had requested and integrate it without satisfying that requirement.
>
>> Yes there is a closed "Withdrawn" state, but I would probably prefer a Reviewer to issue the `/csr unneeded` in that case. Otherwise, A PR author with the role of Committer could withdraw a CSR that a Reviewer had requested and integrate it without satisfying that requirement.
> 
> Yes, that sounds good. What I'm mostly after is what conditions need to be met for the `/csr unneeded` command to succeed. Given this, there are two situations where it should succeed:
> 
> 1. No CSR issue exists.
> 2. A CSR issue exists but has been withdrawn.
> 
> If neither of those two are true, then issuing `/csr unneeded` should result in an error explaining that a CSR has already been filed and will need to be withdrawn first.

@erikj79 Thanks for the review. Could I get your help to sponsor this patch?

-------------

PR: https://git.openjdk.java.net/skara/pull/1245


More information about the skara-dev mailing list