RFR: 1256: Use stream api to simplify the csr issue lookup [v2]

Guoxiong Li gli at openjdk.java.net
Tue Nov 30 16:07:11 UTC 2021

On Tue, 30 Nov 2021 14:49:27 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>   Use stream api instead of the encapsulated method.
> I'm not sure about this change. The Issue interface seems over used and already contains a bunch of methods that do not apply to several implementors. I don't like the idea of adding even more such methods.
> I think we need to try to extract a sub interface from Issue, which is specialized for bugtrackers or Jira or something. Not sure what to name it at this point though. All the links  methods should be moved there, and methods that definitely can't return a pull request, like IssueProject::issue should return the new interface instead. This is part of what I meant with this being hard to solve properly.

@erikj79 I updated the code by using the stream api just now.


PR: https://git.openjdk.java.net/skara/pull/1248

More information about the skara-dev mailing list