RFR: 1186: Backport command stopped working on Gitlab [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Wed Oct 6 10:57:04 UTC 2021

On Tue, 5 Oct 2021 17:54:00 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>   Fix indentation
> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java line 584:
>> 582:         request.post("members")
>> 583:                 .body("user_id", user.id())
>> 584:                 .body("access_level", accessLevel)
> Minor: indentation looks off by 1.

I fixed it. 

There is no consistent formatting standard in Skara. :-( In just this file, I found examples of having indentation in multiples of four spaces, e.g. lines 638-640, or (like here) trying to align with the dot, e.g. lines 608-612. I'd *really* prefer that we introduce a well-defined formatting standard, and stick to it. (Possibly doing a one-shot formatting of all code after establishing the standard.)


PR: https://git.openjdk.java.net/skara/pull/1229

More information about the skara-dev mailing list