RFR: 1201: Multiple command reply messages include 'HostUserDetails' [v3]

Magnus Ihse Bursie ihse at openjdk.java.net
Wed Oct 6 22:23:05 UTC 2021

On Wed, 6 Oct 2021 22:20:35 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Fixing this as the bug reporter suggested, by removing all explicit (broken or not) and duplicated constructions of "@" + username in the command replies, and adding a general @-mention in CommitCommands as well as PR Commands.
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>   Fix makeNonCleanBackportClean

The last failing test was weird. We tried adding the `/clean` command to a backport, and yet somehow it did not get the `clean` label. Although debugging showed that we did set the label, but when we checked for it, it was gone. It turned out that there were an additional task that was run that removed the `clean` label, unless the exact wording as written by the response comment of the `/clean` command were present. (Which now had changed slightly)

This feels extremely brittle. If we should look for special comments made by the bots, we should tag them using `` or something like that. I wonder how many more surprises like this lies dormant in the code...


PR: https://git.openjdk.java.net/skara/pull/1231

More information about the skara-dev mailing list