RFR: Do not print "Optional[repo name]" for backport PR command

Erik Joelsson erikj at openjdk.java.net
Mon Oct 11 13:19:36 UTC 2021

On Thu, 7 Oct 2021 12:48:43 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The sneaky `var` notation has caused a type problem. :-( `var repoName` was in fact `Optional<String>`, not `String`, so when printing this to the user, it was presented like this:
> "Could not automatically backport 481a0456 to Optional[openjdk/jdk11u-dev] due to conflicts in the following files:"
> The naming here is perhaps not my proudest moment, but I did not want to mess with the usage by `potentialTargetRepo` and so I wanted to keep the original value. I think the else-string will never actually show up, due to the isEmpty() check on potentialTargetRepo.

Marked as reviewed by erikj (Lead).


PR: https://git.openjdk.java.net/skara/pull/1232

More information about the skara-dev mailing list