RFR: 885: jbsupdater -pool record consumption modifications

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Oct 12 08:59:07 UTC 2021


On Mon, 11 Oct 2021 21:47:05 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch changes how -pool records are consumed, to help differentiate between OpenJDK and OracleJDK update releases. OracleJDK update releases have moved to using fixVersions with an -oracle suffix. With this change, pool record consumption for such releases will also use an -oracle suffix. I opted for a very simple implementation, where any "-suffix" on a fixVersion is now required as suffix on a -pool version to be a match. I think this makes the most sense and keeps things simple going forward.
> 
> While in the area, I also removed logic for treating N-open fixVersions the same way as N-pool versions. I have no memory of seeing that behavior in action and I believe that implementation was based on a misunderstanding. I could be wrong however, so if anyone can think of a reason to keep that logic, please let me know.

It looks like the patch does what you claim it to do. :-) I can't say I fully understand the -pool (or backporting in general) relationship, though, so I can't really if this is the correct action.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1233


More information about the skara-dev mailing list