RFR: 1167: Update the mapping of files for the client group

Erik Joelsson erikj at openjdk.java.net
Fri Sep 10 12:40:41 UTC 2021


On Fri, 10 Sep 2021 03:01:32 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> A few records related to the client are added to the jdk.json
>
> config/mailinglist/rules/jdk.json line 15:
> 
>> 13:         "client": [
>> 14:             "make/\\w+(Demos|X11)",
>> 15:             "make/autoconf/lib-(alsa|cups|font|freetype|x11)",
> 
> Is it fine in a few places to use the "font" instead of "fontconfig" and "x11" instead of "x11wrappergen"?

My understanding is that the regexp is used to match a prefix. If you add a slash at the end, you enforce a full directory name instead of a partial match. Feel free to rewrite as you like.

> config/mailinglist/rules/jdk.json line 17:
> 
>> 15:             "make/autoconf/lib-(alsa|cups|font|freetype|x11)",
>> 16:             "make/data/(font|x11)",
>> 17:             "make/jdk/src/classes/build/tools/(generatenimbus/|x11wrappergen)",
> 
> Why nimbus has a slash at the end? it can be removed?

As said in the other comment, the slash enforces a full match on a directory instead of a partial. I don't know why this particular dir has a slash when so many others do not. Feel free to rewrite as you like.

-------------

PR: https://git.openjdk.java.net/skara/pull/1217


More information about the skara-dev mailing list