RFR: 1170: Notify bot reposts commit comments if another notifier fails

Erik Joelsson erikj at openjdk.java.net
Mon Sep 13 16:34:52 UTC 2021


On Mon, 13 Sep 2021 15:48:41 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Prevent the CommitCommentNotifier from posting the exact same comment twice.
>
> bots/notify/src/test/java/org/openjdk/skara/bots/notify/comment/CommitCommentNotifierTests.java line 175:
> 
>> 173:     void testNoRepeatedCommitComment(TestInfo testInfo) throws IOException {
>> 174:         try (var credentials = new HostCredentials(testInfo);
>> 175:              var tempFolder = new TemporaryDirectory()) {
> 
> Minor: indentation is different from below lines.

Yes, that seems to be a recurring style choice in the codebase. The contents of the try () is lined up with the start of the opening parentheses.

-------------

PR: https://git.openjdk.java.net/skara/pull/1218


More information about the skara-dev mailing list