Integrated: 1191: CommitCommentWorkItem overwhelms scheduler

Erik Joelsson erikj at
Tue Sep 28 12:46:08 UTC 2021

On Mon, 27 Sep 2021 20:35:13 GMT, Erik Joelsson <erikj at> wrote:

> Main goal if this patch is to fix the scheduling issue caused by CommitCommentsWorkItems::concurrentWith always returning true. To solve this a little nicer, I decided to expand on the idea I introduced a while back with PullRequest::isSame, and add the corresponding method to HostedRepository. This made implementing the ::concurrentWith methods cleaner IMO.
> In addition to this, I decided to add two new gauges to the metrics collection, which would have made it much easier to discover this issue if we already had them. These gauges report the number of active and pending WorkItems we have respectively in the BotRunner, summarized per WorkItem type using labels. To achieve this as nicely as I could, I refactored the BotRunner a little bit, moving all adds and removes for the active and pending maps to specific methods.

This pull request has now been integrated.

Changeset: 91be684a
Author:    Erik Joelsson <erikj at>
Stats:     78 lines in 6 files changed: 59 ins; 7 del; 12 mod

1191: CommitCommentWorkItem overwhelms scheduler

Reviewed-by: kcr



More information about the skara-dev mailing list