RFR: SKARA-1194: Implement git webrev --no-comments option [v2]

Aleksey Shipilev shade at openjdk.java.net
Wed Sep 29 05:54:01 UTC 2021


On Tue, 28 Sep 2021 16:04:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> It's unfortunate to have a field/variable with a negation in the name, but in this case it matches the argument so it could be ok. Maybe worth inverting the internal variable/field? What do you think? I'm approving this as it is if you don't want to.

OK, we can drop "no" from field names and negate it when reading from cli. See new commit.

-------------

PR: https://git.openjdk.java.net/skara/pull/1224


More information about the skara-dev mailing list