RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v2]
Kevin Rushforth
kcr at openjdk.java.net
Mon Apr 11 16:02:35 UTC 2022
On Mon, 11 Apr 2022 13:51:23 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> I understand that this is how it would work with the current logic, and I don't agree with it. Declaring the need for a JEP and a CSR are different, so they do not need to follow the same model (though I'm not sure I agree with the limitation on `/csr unneeded` either).
>>
>> In order for a committer to mishandle this, they would have to actively issue `/jep unneeded` and then integrate. I think it's unlikely to happen by mistake, and mistakes are what this feature intends to protect against. We already trust committers to handle `/integrate` on their own, this isn't about protecting against malicious committers.
>
>> We already trust committers to handle /integrate on their own, this isn't about protecting against malicious committers.
>
> I agree with you now and I will fix it later.
> I understand that this is how it would work with the current logic, and I don't agree with it. Declaring the need for a JEP and a CSR are different, so they do not need to follow the same model (though I'm not sure I agree with the limitation on `/csr unneeded` either).
I feel that the current limitation on `/csr unneeded` is a good one, but I also agree that JEP need not (and probably should not) have this same restriction.
-------------
PR: https://git.openjdk.java.net/skara/pull/1297
More information about the skara-dev
mailing list