RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v4]
Erik Joelsson
erikj at openjdk.java.net
Mon Apr 11 19:24:27 UTC 2022
On Mon, 11 Apr 2022 19:05:19 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Hi all,
>>
>> This patch implements the features about the `/jep` command and JEP bot. The detailed designs and discussions are listed at [1][2].
>>
>> Thanks for taking the time to review.
>>
>> Best Regards,
>> -- Guoxiong
>>
>> [1] https://mail.openjdk.java.net/pipermail/skara-dev/2021-December/005481.html
>> [2] https://mail.openjdk.java.net/pipermail/skara-dev/2022-March/005770.html
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>
> Add a test case about the jira api. Fix a bug found by this test case.
issuetracker/src/test/java/org/openjdk/skara/issuetracker/jira/JiraProjectTests.java line 33:
> 31: import static org.junit.jupiter.api.Assertions.assertTrue;
> 32:
> 33: public class JiraProjectTests {
To my knowledge, no automatic tests in the Skara project use remote services. Until we decide to change this policy, or find a reasonable way to run such tests, please mark this test as disabled.
Suggestion:
/**
* To be able to run the tests, you need to remove or comment out the @Disabled
* annotation first.
*/
@Disabled("Manual")
public class JiraProjectTests {
-------------
PR: https://git.openjdk.java.net/skara/pull/1297
More information about the skara-dev
mailing list