RFR: 1396: Gitlab MR merged outside of Skara causes NPE in mlbridge

Kevin Rushforth kcr at openjdk.java.net
Tue Apr 12 19:57:33 UTC 2022


On Tue, 12 Apr 2022 19:06:02 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> In gitlab, if an MR is merged through Gitlab, without the user of Skara, we end up in a retry loop getting NPE in the mlbridge bot. This is caused by trying to extract the value of the "closed_by" field of the PR object. This patch adds a fallback to instead look at the "merged_by" field instead.

Looks good.

-------------

Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1298


More information about the skara-dev mailing list