RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v5]

David Holmes dholmes at openjdk.java.net
Wed Apr 13 01:14:00 UTC 2022

On Mon, 11 Apr 2022 19:39:03 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch implements the features about the `/jep` command and JEP bot. The detailed designs and discussions are listed at [1][2].
>> Thanks for taking the time to review.
>> Best Regards,
>> -- Guoxiong
>> [1] https://mail.openjdk.java.net/pipermail/skara-dev/2021-December/005481.html
>> [2] https://mail.openjdk.java.net/pipermail/skara-dev/2022-March/005770.html
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Disable the test in JiraProjectTests.

The original proposal for this solicited only two responses from myself and Erik and we both expressed concerns that this was beyond the scope of discussion for skara-dev - codifying these aspects of the JEP process (particularly with the original proposed changes to JBS) needed to be done as part of the JEP process. So that "discussion" went nowhere. I apologise that I did not get back regarding looking into a more suitable place to discuss the JBS changes - there really isn't one, so jdk-dev (as suggested by Erik at the time) seems a reasonable place.

After that initial "discussion" nothing was said for three months at which point you decided to proceed with a reduced proposal. I would have taken the lack of further discussion as sign of either a general lack of interest about the proposal, or a sign that it was not being seen by the right people in the right place. 

So the current simplified proposal addresses the basic need expressed in SKARA-1096, and prevents the accidental integrations that you rightly point out have actually occurred. I withdraw, and apologise for, my comment that this feature is "unwarranted".

I would still like to see the proposal announced on a broader mailing, such as jdk-dev, to increase awareness and potentially garner some feedback.



PR: https://git.openjdk.java.net/skara/pull/1297

More information about the skara-dev mailing list