RFR: 1397: Skara doesn't handle tags with more than 4 digits in version number

Kevin Rushforth kcr at openjdk.java.net
Thu Apr 14 12:47:58 UTC 2022

On Wed, 13 Apr 2022 21:15:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> To be able to react to new tags, Skara needs to know how to parse our tag formats. For this we have the OpenJDKTag class. The current pattern for Verona based version numbers in this class is limited to tags with 4 digit version numbers. This becomes a problem when a JDK release uses more of the up to 7 possible version digits currently allowed in mainline since [JDK-8207849](https://bugs.openjdk.java.net/browse/JDK-8207849). 
> This patch raises the limit to 7 digits to match what is currently possible in the JDK build. I'm also removing the redundant and incomplete "OpenJDKVersionPattern" which seemed to not serve any purpose as the existing OpenJFXVersionPattern covered everything for both JDK and JFX tags.

Marked as reviewed by kcr (Reviewer).


PR: https://git.openjdk.java.net/skara/pull/1299

More information about the skara-dev mailing list