[Investigation] Add JEP check to the PR
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Thu Apr 14 13:17:39 UTC 2022
On 2022-04-13 18:06, mark.reinhold at oracle.com wrote:
> I have to ask: Is this really worth the trouble?
If Guoxiong is taking the time to implement it, why not?
I like the general concept -- it is similar to the /csr command. I think
it is useful to have a correspondence between PRs and JEPs, just as we
have a correspondence between PRs and CSR requests.
(The idea has been along for a while, and I'm not certain the current
suggestion is 100% correct, but it is certainly good enough to start
with, and then we can adjust issues that arise later on -- just as we
have done with almost all of the Skara development. Start by doing
mostly right, and then fix edge cases or issues we discover later on.)
> We’ve targeted and integrated over three hundred JEPs since the
> inception of the process in 2011. How many of those, besides JEP
> 295, were integrated prematurely?
> The solution you offer requires the JEP implementor to remember to
> type the `/jep` command in the PR. They could forget to do that
> just as easily as they forget to check the targeting status of the
> JEP itself.
> Now if you could automagically determine that a PR issue is a JEP
> implementation and block it when the JEP is not targeted, without
> the JEP implementor having to do anything special, then that might
> be more compelling -- but still, is it a problem worth solving?
> - Mark
More information about the skara-dev