RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v5]
Erik Joelsson
erikj at openjdk.java.net
Tue Apr 19 15:12:30 UTC 2022
On Tue, 12 Apr 2022 12:52:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> I think this is totally unwarranted and there was not enough previous discussion at the JDK level to actually conclude anything about the need for this and how it should work. A JEP is not like a CSR-request. It is extremely rare to create an issue and raise a PR and have someone then say "this really needs a JEP".
>>
>> David
>
>> I think this is totally unwarranted and there was not enough previous discussion at the JDK level to actually conclude anything about the need for this and how it should work. A JEP is not like a CSR-request. It is extremely rare to create an issue and raise a PR and have someone then say "this really needs a JEP".
>
> That isn't the intended usecase here. To issue the command, a JEP must already exist, as you have to reference a bugid/jepid pointing to the JEP. This command is mostly intended for the author to run, to make it clearer that the PR is related to a JEP.
> @erikj79 During revising the code, I find two issues:
>
> 1. the `AllowCommand` and `RejectCommand` are not used in the `PullRequestCommandWorkItem`
> 2. the `AllowCommand`, `RejectCommand` and `OpenCommand` are not documented at the wiki [1]
>
> Is it the intentional behavious or a bug or unfinished work?
>
> [1] https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands
The OpenCommand should probably be documented on the wiki. The other two I don't know the purpose of. I would say unfinished/unclear/prototype work from pretty early in Skara development. I don't think we need them.
-------------
PR: https://git.openjdk.java.net/skara/pull/1297
More information about the skara-dev
mailing list