RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v8]

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Apr 19 15:37:00 UTC 2022

On Mon, 18 Apr 2022 17:04:51 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch implements the features about the `/jep` command and JEP bot. The detailed designs and discussions are listed at [1][2].
>> Thanks for taking the time to review.
>> Best Regards,
>> -- Guoxiong
>> [1] https://mail.openjdk.java.net/pipermail/skara-dev/2021-December/005481.html
>> [2] https://mail.openjdk.java.net/pipermail/skara-dev/2022-March/005770.html
> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
>  - Redo: Change labels after comment.
>  - Revert: Change labels after comment.

FWIW, I've looked through all the code in the PR now. I added a few suggestions on user fronting strings, otherwise I have not much to add. I'll mark this as approved, but you do need to get Erik's approval as well. (And please fix the strings :))


Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1297

More information about the skara-dev mailing list