RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v8]

[Guoxiong Li]

On Tue, 19 Apr 2022 15:19:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Redo: Change labels after comment.
>>  - Revert: Change labels after comment.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/JEPCommand.java line 62:
> 
>> 60:                 The project prefix of the issue ID (`JDK-` in the above examples) is optional.
>> 61:                 But the `JEP-` or `jep-` prefix is required when you provide a JEP ID.
>> 62:                 And the issue type must be `JEP`.
> 
> Suggestion:
> 
>                 The project prefix (`JDK-` in the above examples) is optional if you use an issue ID. 
>                 The issue type in that case must be `JEP`.
>                 The `JEP-` or `jep-` prefix is required if you instead provide a JEP ID.

Fixed.

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/JEPCommand.java line 68:
> 
>> 66:     private Optional<Issue> getJepIssue(String args, PullRequestBot bot) {
>> 67:         Optional<Issue> jbsIssue;
>> 68:         if (args.startsWith("jep-") || args.startsWith("JEP-")) {
> 
> Suggestion:
> 
>         if (args.toUpperCase().startsWith("JEP-")) {
> 
> 
> Then variations like "Jep-123" is also accepted.

Fixed and added a test case.

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/JEPCommand.java line 150:
> 
>> 148:     @Override
>> 149:     public String description() {
>> 150:         return "require a JDK Enhancement Proposal for this pull request";
> 
> Suggestion:
> 
>         return "require a JDK Enhancement Proposal (JEP) for this pull request";

Fixed.

-------------

PR: https://git.openjdk.java.net/skara/pull/1297