RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v8]

Guoxiong Li gli at openjdk.java.net
Tue Apr 19 16:56:55 UTC 2022


On Tue, 19 Apr 2022 15:34:04 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Redo: Change labels after comment.
>>  - Revert: Change labels after comment.
>
> FWIW, I've looked through all the code in the PR now. I added a few suggestions on user fronting strings, otherwise I have not much to add. I'll mark this as approved, but you do need to get Erik's approval as well. (And please fix the strings :))

@magicus Thanks for the review. I updated the code just now.

-------------

PR: https://git.openjdk.java.net/skara/pull/1297


More information about the skara-dev mailing list