Fwd: Integrated: 8285012: Problemlist gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java

[Magnus Ihse Bursie]

On 2022-04-19 21:35, erik.joelsson at oracle.com wrote
> On 2022-04-19 12:10, Magnus Ihse Bursie wrote:
>> On 2022-04-19 17:52, erik.joelsson at oracle.com wrote:
>>> It looks like the mailinglist bridge didn't get a chance to send any 
>>> emails before the PR was already integrated. The PR didn't initially 
>>> have any label, so there wasn't much time between it getting 
>>> 'hotspot-gc' and being integrated. Even though it probably should 
>>> say RFR for the first few emails, it's also not wrong to mark them 
>>> as integrated, as the PR was already integrated and didn't need any 
>>> more review.
>>
>> So all mails that are sent after a PR is actually integrated are 
>> prefixed with "Integrated:" instead of "RFR:"? I thought it was due 
>> to the *type* of mail, so mails originating from Github comments got 
>> RFR (or created PRs), while mails originating from bots actually 
>> integrating the PR starts with "Integrated". But that is not the case?
>>
> All the kinds of mails you are describing here are sent by the 
> MailingListBridgeBot. I wasn't aware of this until now, but that is 
> apparently how it works. The prefix is based on the current state of 
> the PR. See [1] if you are curious.

Oooookay...

>> This particular case might not be common, but it is definitely 
>> confusing. I'd consider it a bug.
>>
> It may be confusing, it depends on your assumption/internal model of 
> how Skara works. I kinda think it makes sense, but could go either way 
> if I got to pick at equal cost. However, given that this is the way it 
> currently works, I'm going to lean quite heavily in that direction as 
> I don't think rewriting this logic is a good idea.
I'll grudgingly agree that perhaps we should leave it be then. I'm not 
happy about it, but "if it ain't broken don't fix it" -- the risks and 
costs involved in changing this is too large.

/Magnus

>
> /Erik
>
> [1] 
> bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java:105
>> /Magnus
>>
>>>
>>> /Erik
>>>
>>> On 2022-04-19 08:46, Magnus Ihse Bursie wrote:
>>>> This mail subject starts with "Integrated:" even though it is an 
>>>> RFR. WTF? Is this just an odd error caused by cosmic ray 
>>>> bitflipping, or something we should investigate?
>>>>
>>>> /Magnus
>>>>
>>>>
>>>> -------- Forwarded Message --------
>>>> Subject:     Integrated: 8285012: Problemlist 
>>>> gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java
>>>> Date:     Tue, 19 Apr 2022 15:34:39 GMT
>>>> From:     Thomas Schatzl <tschatzl at openjdk.java.net>
>>>> To:     hotspot-gc-dev at openjdk.java.net
>>>>
>>>>
>>>>
>>>> Hi all,
>>>>
>>>> please review this problemlisting of the test 
>>>> `gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java` since it 
>>>> causes lots of noise.
>>>>
>>>> Thanks,
>>>> Thomas
>>>>
>>>> -------------
>>>>
>>>> Commit messages:
>>>> - Problemlist test
>>>>
>>>> Changes: https://git.openjdk.java.net/jdk/pull/8299/files
>>>> Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8299&range=00
>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8285012
>>>> Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
>>>> Patch: https://git.openjdk.java.net/jdk/pull/8299.diff
>>>> Fetch: git fetch https://git.openjdk.java.net/jdk 
>>>> pull/8299/head:pull/8299
>>>>
>>>> PR: https://git.openjdk.java.net/jdk/pull/8299
>>