RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v8]

Guoxiong Li gli at openjdk.java.net
Wed Apr 20 10:52:25 UTC 2022

On Tue, 19 Apr 2022 15:57:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> You are correct Magnus, that would be nicer indeed.
> The drawback of doing that is that JEPCommand would still need to implement the old handle method, which doesn't make sense for it to do. Unless we also add a default empty implementation for the original handle method.
> @lgxbslgx If you want to change it to avoid touching all the other commands, using default methods in the interface instead, that's ok, but I'm also ok leaving it as it is.

> @erikj79, @magicus and I may feel good with it because we added or reviewed it. But in the future, the new SKARA developers may be confused by it. In other words, the maintainment of the project may become a little more complex.

@magicus previously, I thought it is not good to add the "bridge" "long" methods because it may confused other developers.

> There is no need nor good reason to push these additional argument to command implementations.

But now, I think that the additional parameter `labelsToAdd` and `labelsToRemove` which have not used in much cammands confused the developers, too and are more terrible. So I agree with you and updated the code just now.


PR: https://git.openjdk.java.net/skara/pull/1297

More information about the skara-dev mailing list