RFR: 1406: Two GitHub APIs don't return `patch` field when `per_page` argument exceeds 70 [v2]

[Guoxiong Li]

On Fri, 22 Apr 2022 14:00:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment.
>
> forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java line 740:
> 
>> 738:     public Diff diff() {
>> 739:         var files = request.get("pulls/" + json.get("number").toString() + "/files")
>> 740:                            .param("per_page", "50")
> 
> Can we add a comment explaining the need for per_page? Something like:
> 
> "Need to specify an explicit per_page < 70 to guarantee that we get patch information in the result set."

Added.

-------------

PR: https://git.openjdk.java.net/skara/pull/1302