RFR: 282: Make the review requirements more explicit in the progress list

David Holmes dholmes at openjdk.java.net
Mon Apr 25 22:40:49 UTC 2022

On Mon, 25 Apr 2022 06:11:13 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> > These are informal rules not codified anywhere so how are you determining what criteria to report? Hotspot generally requires two reviews, but that is not a blanket rule.
> The concrete reviews information depends on the configuration in `.jcheck/conf` and the `reviewers` command. For example, please see this [PR](https://github.com/openjdk/jdk/pull/7204#issuecomment-1032111596), when someone typed `/reviewers 2`, the bot replied `The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers)`. This patch puts similar information to the `Progress` of the PR body so that developers can read it earily instead of searching it in the comments.

I see - that makes sense. I'm not sure if that is what SKARA-282 was actually referring to though.


PR: https://git.openjdk.java.net/skara/pull/1305

More information about the skara-dev mailing list