RFR: 282: Make the review requirements more explicit in the progress list

Guoxiong Li gli at openjdk.java.net
Mon Apr 25 23:33:29 UTC 2022

On Mon, 25 Apr 2022 23:17:32 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> To do this the TooFewReviewersIssue would need to hold the requirements string from the configuration, but I think it makes enough sense for it to do that. ReviewersCheck has access to it and can provide it to the constructor.

I tried this way at first when I solved this issue. But then I found the ReviewersCheck doesn’t always return the TooFewReviewersIssue which means the message may miss sometimes. And if we return the message in all the issues of the ReviewersCheck, the message may also miss when the ReviewersCheck passes without any issue.


PR: https://git.openjdk.java.net/skara/pull/1305

More information about the skara-dev mailing list