RFR: 1118: The Skara PR bot should not block on a CSR if not enabled for a repo [v2]

Guoxiong Li gli at openjdk.java.net
Fri Apr 29 15:16:24 UTC 2022


On Fri, 29 Apr 2022 13:47:41 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I think it would be useful.

Filed https://bugs.openjdk.java.net/browse/SKARA-1419 to follow up.

>> If default is false, we must configurate it as ture in the corresponding projects such as JDK project when deploying. If default is false and we forget to congurate it, the dev flow will be blocked. I am good to change it if you can confirm all the configuration files are changed correctly.
>
> Yes, I will need to update the configuration, that's fine. The set of repositories we have with CSR bot configured is very low compared to the total number of repos. It makes much more sense to have two positive configuration options that need to be in sync.

Fixed.

-------------

PR: https://git.openjdk.java.net/skara/pull/1308


More information about the skara-dev mailing list