RFR: 1516: Command 'git pr integrate' gets error message 'time out'

Guoxiong Li gli at openjdk.org
Tue Aug 9 16:27:05 UTC 2022

On Tue, 9 Aug 2022 13:05:17 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> I tried the command `git pr integrate 1341` to integrate SKARA-1495. The command replies `error: timed out waiting for response to /integrate command`. It is because the bot added a comment `@lgxbslgx Pushed as commit XXX.` so that this line is not started with `Pushed as commit`.
> This patch fixes the bug by using a pattern matcher instead of judging the beginning of the line. And I verified this patch by using the command `git pr integrate 1344` to integrate SKARA-1463 just now. It works well and replies `@lgxbslgx Pushed as commit 35b23b882393c33565e49ec0399adba7e8eb2f5b`. But I have not verified the sponsor flow because I don't have a chance to do that now.
> Thanks for taking the time to review.
> Best Regards,
> -- Guoxion

All the code in cli module don’t have tests now. It seems be hard to add tests to verify the client commands so the previous developers didn’t add any test for it. I don’t really know whether it has a good way to add such test, but I am still thinking.


PR: https://git.openjdk.org/skara/pull/1352

More information about the skara-dev mailing list